feat(ut): Add test #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthusLiang
reviewed
Aug 29, 2022
| config = require(path.resolve(configFile)); | ||
| if (!config) { | ||
| config = require(path.resolve(configFile)); | ||
| } |
There was a problem hiding this comment.
Can we only read config from _config? Use Object.assign?
There was a problem hiding this comment.
We still want to support the config file way,
So the user doesn't have to write js, if they prefer cli
ArthusLiang
reviewed
Aug 29, 2022
| @@ -110,7 +117,8 @@ async function init() { | |||
| }, | |||
| tokenPath: '.', | |||
| } | |||
| await fs.writeFile(configFile, `module.exports = ${JSON.stringify(config, null, 2)}`, 'utf-8'); | |||
|
|
|||
| return _dry ? config : await fs.writeFile(configFile, `module.exports = ${JSON.stringify(config, null, 2)}`, 'utf-8'); | |||
There was a problem hiding this comment.
Do we need print config if we use dry mode?
There was a problem hiding this comment.
The init would return the config in dry run,
How to use the return stuff would up to the user,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #35
Not cover yet