Fix to codecov file path search #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codecov.io upload script appears to rely on the filepath of source codes at compile time, and was unable to find the output when called from .testing or the work directories. In this patch, we now move to `.testing/build/symmetric` (the gcov-enabled build) before running the uploader script. This is possibly required after the recent security alert connected to the codecov.io uploader script. Sadly, our coverage report failures went undetected for several months. The `-Z` flag has also been added to the script, which returns a nonzero error code if it fails. It's not yet clear to me if a missing file registers as a fail, but it may help to detect future problems.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1460 +/- ##
=============================================
+ Coverage 0 29.29% +29.29%
=============================================
Files 0 234 +234
Lines 0 70594 +70594
=============================================
+ Hits 0 20681 +20681
- Misses 0 49913 +49913
Continue to review full report at Codecov.
|
adcroft
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codecov.io upload script appears to rely on the filepath of source
codes at compile time, and was unable to find the output when called
from .testing or the work directories. In this patch, we now move to
.testing/build/symmetric(the gcov-enabled build) before running theuploader script.
This is possibly required after the recent security alert connected to
the codecov.io uploader script. Sadly, our coverage report failures
went undetected for several months.
The
-Zflag has also been added to the script, which returns a nonzeroerror code if it fails, although it would not have caught the previous issue.