Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Remove quotes in COVERAGE #1212

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

marshallward
Copy link
Collaborator

The COVERAGE variable was incorrectly quoted, and was causing incorrect
quotes in the compile flag arguments.

This patch removes the redundant quotes.

The COVERAGE variable was incorrectly quoted, and was causing incorrect
quotes in the compile flag arguments.

This patch removes the redundant quotes.
@codecov-commenter
Copy link

Codecov Report

Merging #1212 into dev/gfdl will decrease coverage by 0.01%.
The diff coverage is 35.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1212      +/-   ##
============================================
- Coverage     46.08%   46.07%   -0.02%     
============================================
  Files           214      224      +10     
  Lines         69399    70592    +1193     
============================================
+ Hits          31984    32522     +538     
- Misses        37415    38070     +655     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
src/ALE/MOM_regridding.F90 31.47% <0.00%> (-0.17%) ⬇️
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123f664...7bea824. Read the comment docs.

@adcroft adcroft merged commit c9294aa into mom-ocean:dev/gfdl Sep 22, 2020
@marshallward marshallward deleted the coverage_quote_fix branch January 18, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants