Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent array copies in MOM_wave_structure #1182

Closed
raphaeldussin opened this issue Aug 18, 2020 · 1 comment · Fixed by #1183
Closed

inconsistent array copies in MOM_wave_structure #1182

raphaeldussin opened this issue Aug 18, 2020 · 1 comment · Fixed by #1183

Comments

@raphaeldussin
Copy link
Contributor

@Hallberg-NOAA I know you're looking at this rn but just wanted to point out this problem:

when layers are merged, this becomes incorrect:

https://github.com/NOAA-GFDL/MOM6/blob/dd75807adddb749aecee20cf6a992904269b5900/src/diagnostics/MOM_wave_structure.F90#L488

also similar issues on line 521 and below.
I can submit a PR unless it would interfere with your rewriting

@Hallberg-NOAA
Copy link
Collaborator

@raphaeldussin, I need to put my work on MOM_wave_structure.F90 on hold for the next few weeks, so if you are working on MOM_wave_structure.F90 and are able to identify and correct any bugs, please do not hesitate to fix them and put in a PR. To the best of my knowledge, there is very limited testing of the MOM_wave_structure.F90 code, so if along the way you identify a good test case to add this to, that would also be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants