Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about how to instantiate a selection callback #11

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

nlarusstone
Copy link
Contributor

@nlarusstone nlarusstone commented Jun 30, 2023

Hi!

In the spirit of trying to help with documentation (molstar/molstar#138), I wanted to put up a small PR which was confusing to me as a new user of molstar.

It took me quite a bit of time to find molstar/molstar#412, but this eventually helped both with my question about callbacks as well as how to go from Loci -> residues.

@nlarusstone
Copy link
Contributor Author

Let me know if there's anything else I can provide here

Copy link
Member

@dsehnal dsehnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing @nlarusstone and sorry for the late merge, forgot to look at it when you made this,

@dsehnal
Copy link
Member

dsehnal commented Dec 15, 2023

@nlarusstone would you please mind resolving the merge conflict?

@nlarusstone
Copy link
Contributor Author

Resolved!

@dsehnal dsehnal merged commit a1b89d9 into molstar:master Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants