Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using explicit version of Docker image #129

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Using explicit version of Docker image #129

merged 3 commits into from
Feb 10, 2024

Conversation

paulsaxe
Copy link
Collaborator

  1. Migrating to using the explicit version of the seamm-mopac container that is matched to the plug-in.
  2. Removed the ENTRYPOINT command from the Docker image and rely on just the COMMAND for the default.
  3. Updated the README to reflect using the explicit version of the Docker image.

@paulsaxe paulsaxe added the bug Something isn't working label Feb 10, 2024
@paulsaxe paulsaxe requested a review from seamm February 10, 2024 09:23
seamm
seamm approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Merging #129 (74f04ad) into main (caa2dbf) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

@seamm seamm merged commit 9b90f9f into molssi-seamm:main Feb 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamm seamm seamm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsaxe @seamm