Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tailwind-components): form modal #4814

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

feat(tailwind-components): form modal #4814

wants to merge 32 commits into from

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

  • show form in a modal

  • lots of teaks to modal, changes need to be passed on to current modal users

  • replace hard-coded styles with theme vars

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

connoratrug and others added 23 commits February 21, 2025 17:07
@connoratrug
feat: Add/Edit a row in fullpage mode
5e1fe33 
- add sample page
- add fullpage layout
- update page header to allow title pre and post fix

todo: fix fields component, pull out legend other info parts, fix breadcrumb-styling, add draft badge, add (dummy) action buttons
@connoratrug
Merge branch 'master' of github.com:molgenis/molgenis-emx2 into feat/…
272202f 
…tw-edit-row-page-sample
@connoratrug
slipt into components wip
6edb3c3
@connoratrug
format
1a0821f
@connoratrug
Merge branch 'master' into feat/tw-edit-row-page-sample
ca3bbb3
@connoratrug
add missing type info
47b1b9d
@connoratrug
add demo page to playground index
9bfdc6f
@connoratrug
split formFields and fromLegend into separate components
d458003
@connoratrug
Merge branch 'master' of github.com:molgenis/molgenis-emx2 into feat/…
03fbdd7 
…tw-edit-row-page-sample
@connoratrug
remove generated code barf
884ab8c
@connoratrug
Merge branch 'master' into feat/tw-edit-row-page-sample
1f34909
@connoratrug
fix test
c146128
@connoratrug
Merge branch 'master' of github.com:molgenis/molgenis-emx2 into feat/…
2b0e0d5 
…tw-edit-row-page-sample
@connoratrug
fix scrolling
3ad4717
@connoratrug
feat: form modal
514eba6 
- add sample page
@connoratrug
Merge branch 'master' into feat/formModal
59380a9
@connoratrug
fix: imporove dark theme outlkine button style
6661980
@connoratrug
Merge branch 'feat/formModal' of github.com:molgenis/molgenis-emx2 in…
5e82f59 
…to feat/formModal
@connoratrug
fix: molgenis theme form modal text color
bc5228c 
- add css variable to differentiate a 'normal' title on contast background and a special 'pop' title color
- update the cta cards to use the new pop variant
@connoratrug
cleanup legens component bg
cb2d324
@connoratrug
fix: fix theme colors for form ( light, dark, molgenis, umcg)
880a718
@connoratrug
fix close icon color
e228a3f
@connoratrug
Merge branch 'master' of github.com:molgenis/molgenis-emx2 into feat/…
fd0402d 
…formModal
@connoratrug connoratrug self-assigned this Mar 7, 2025
@connoratrug
page form row edit
c196410 
- move playground header into component
- add form actions ( sticky )
- add form error
@connoratrug
fix form bg theme color
96c8cd2
@connoratrug
fix img ref
d6990d7
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@connoratrug connoratrug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@connoratrug