feat(emx2): JSON api for reports #4410
Open
+111
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswertz
requested changes
Oct 29, 2024
| for (Row row : rows) { | ||
| result.add(row.getValueMap()); | ||
| } | ||
| jsonResponse.put(name, result); |
There was a problem hiding this comment.
this is nice, but ... we could make SQL that produces JSON itself. So I would propose we adapt this such that if the row has only one value, and that value is of type JSONB that we return that value? Could you try to make testcase report that produces JSON to test this? Then we could amend the docs to make that clear
There was a problem hiding this comment.
The reports indeed break if you use jsonb I added this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4360
What are the main changes you did:
how to test:
todo: