-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(emx2): JSON api for reports #4410
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, puts a smile on my face, but one bonus request see comments
for (Row row : rows) { | ||
result.add(row.getValueMap()); | ||
} | ||
jsonResponse.put(name, result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice, but ... we could make SQL that produces JSON itself. So I would propose we adapt this such that if the row has only one value, and that value is of type JSONB that we return that value? Could you try to make testcase report that produces JSON to test this? Then we could amend the docs to make that clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reports indeed break if you use jsonb I added this.
Quality Gate passedIssues Measures |
Fixes: #4360
What are the main changes you did:
how to test:
todo: