Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce benchmark harness overhead #6

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

arthurprs
Copy link
Contributor

I was hitting some significant bottlenecks due to the benchmark harness overhead. I narrowed it down to the 2 limitations below, which lead to skewed results:

  • overhead of parsing each line and generating a command
  • single producer doing the command generation cannot keep the consumer threads busy

This change takes the easy (pragmatic) route and fully pre-process the benchmark commands before performing the benchmark. This solves both of the issues above.

Although effective, this change isn't particularly ideal, as it requires 4GB memory to benchmark the DS1 dataset.

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Although effective, this change isn't particularly ideal, as it requires 4GB memory to benchmark the DS1 dataset.

I am okay with that. Thank you for working on this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants