Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quick_cache, stretto and hashlink caches #1

Merged

Conversation

arthurprs
Copy link
Contributor

@arthurprs arthurprs commented Aug 16, 2022

Thank for writing this benchmarking suite, it's quite useful. I added quick cache, stretto and hashlink to it plus some small improvements.

  • Reduce benchmark machinery overhead by avoiding allocations on the parsing step
  • Add support for more trace formats (LIRS/LIRS2)
  • Swap FNV with a stronger, but still fast hasher
  • Benchmark can take multiple client counts and trace file names from the cli

* Reduce benchmark machinery overhead avoiding allocations on parsing step
* Add support for more trace formats (LIRS/LIRS2)
* Swap FNV with a stronger, but still fast hasher
* Benchmark can take multiple client counts and trace file names from the cli
@tatsuya6502 tatsuya6502 self-assigned this Aug 23, 2022
@tatsuya6502 tatsuya6502 self-requested a review August 23, 2022 12:49
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Great additions. Thank you so much!

I ran it with quick_cache, stretto and hashlink caches enabled. quick_cache looks very interesting!

@tatsuya6502 tatsuya6502 merged commit 374c423 into moka-rs:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants