Upgrade thiserror to 2.0 and disable default features #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thiserror has had a 2.0 release that does include breaking changes but does not appear to impact moka's use of thiserror. By upgrading, we can stay closer to the latest version of thiserror and avoid needing to compile multiple versions of thiserror in consumers who are themselves using a newer version of thiserror.
We're barely using thiserror at all in moka, and we don't require any of thiserror's features. We might also want to consider not using thiserror at all and pruning that whole dependency tree.
|
New contributor here! I was just working on optimizing a dependency tree in a project, and noticed that we were pulling in 2 versions of thiserror, the older one coming from moka. As I mentioned in one of the commits, I also noticed that we're barely using thiserror here; if you were interested I'd be happy to PR a change to just drop it as a dependency and manually impl Error for the one place (that I've seen) we're using it outside of tests. Maybe we could just move it to a dev-dependency or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable default-features on thiserror
We're barely using thiserror at all in moka, and we don't require any of
thiserror's features.
We might also want to consider not using thiserror at all and pruning
that whole dependency tree.
Upgrade thiserror to 2.0
Thiserror has had a 2.0 release that does include breaking changes but
does not appear to impact moka's use of thiserror.
By upgrading, we can stay closer to the latest version of thiserror and
avoid needing to compile multiple versions of thiserror in consumers who
are themselves using a newer version of thiserror.