-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unmaintained paste
crate from the dev-dependencies
#504
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR removes the unmaintained paste crate from the development dependencies and updates the related test macros accordingly. The changes include removing the paste::paste import, adjusting macro definitions to use plain function definitions for test cases, and updating Cargo.toml by removing the paste dependency.
Reviewed Changes
File | Description |
---|---|
tests/entry_api_sync.rs | Removed paste macro usage and updated test function naming conventions. |
Cargo.toml | Removed the paste dependency in favor of direct test naming. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 94.19% 94.24% +0.05%
==========================================
Files 43 43
Lines 20433 20433
==========================================
+ Hits 19246 19257 +11
+ Misses 1187 1176 -11 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request removes the unmaintained paste crate from the dev-dependencies and updates related test code accordingly.
- Removed the paste crate from Cargo.toml.
- Updated CHANGELOG.md to document the removal.
- Modified test macros in tests/entry_api_sync.rs to eliminate paste usage and update test function naming.
Reviewed Changes
File | Description |
---|---|
CHANGELOG.md | Added a changelog entry for removal of the paste crate. |
tests/entry_api_sync.rs | Removed paste macro calls and updated test function naming in macros. |
Cargo.toml | Removed the unmaintained paste crate from dev-dependencies. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/entry_api_sync.rs:21
- [nitpick] Ensure that the identifier provided to the macro includes a clear test naming convention (for example, a 'test_' prefix) to maintain consistency and improve readability.
fn $name() {
Fixes #503. (RUSTSEC-2024-0436)