Replace futures with futures-util #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsuya6502
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Nice catch. I overlooked the er-exports in futures.
This has reduced the number of dependencies:
Before
$ cargo tree --all-features
...
├── futures v0.3.16
│ ├── futures-channel v0.3.16
│ │ ├── futures-core v0.3.16
│ │ └── futures-sink v0.3.16
│ ├── futures-core v0.3.16
│ ├── futures-executor v0.3.16
│ │ ├── futures-core v0.3.16
│ │ ├── futures-task v0.3.16
│ │ └── futures-util v0.3.16
│ │ ├── futures-channel v0.3.16 (*)
│ │ ├── futures-core v0.3.16
│ │ ├── futures-io v0.3.16
│ │ ├── futures-macro v0.3.16 (proc-macro)
│ │ │ ├── proc-macro-hack v0.5.19 (proc-macro)
│ │ │ ├── proc-macro2 v1.0.28
│ │ │ │ └── unicode-xid v0.2.2
│ │ │ ├── quote v1.0.9
│ │ │ │ └── proc-macro2 v1.0.28 (*)
│ │ │ └── syn v1.0.75
│ │ │ ├── proc-macro2 v1.0.28 (*)
│ │ │ ├── quote v1.0.9 (*)
│ │ │ └── unicode-xid v0.2.2
│ │ │ [build-dependencies]
│ │ │ └── autocfg v1.0.1
│ │ ├── futures-sink v0.3.16
│ │ ├── futures-task v0.3.16
│ │ ├── memchr v2.4.1
│ │ ├── pin-project-lite v0.2.7
│ │ ├── pin-utils v0.1.0
│ │ ├── proc-macro-hack v0.5.19 (proc-macro)
│ │ ├── proc-macro-nested v0.1.7
│ │ └── slab v0.4.4
│ │ [build-dependencies]
│ │ └── autocfg v1.0.1
│ ├── futures-io v0.3.16
│ ├── futures-sink v0.3.16
│ ├── futures-task v0.3.16
│ └── futures-util v0.3.16 (*)After
├── futures-util v0.3.16
│ ├── futures-core v0.3.16
│ ├── futures-macro v0.3.16 (proc-macro)
│ │ ├── proc-macro-hack v0.5.19 (proc-macro)
│ │ ├── proc-macro2 v1.0.28
│ │ │ └── unicode-xid v0.2.2
│ │ ├── quote v1.0.9
│ │ │ └── proc-macro2 v1.0.28 (*)
│ │ └── syn v1.0.75
│ │ ├── proc-macro2 v1.0.28 (*)
│ │ ├── quote v1.0.9 (*)
│ │ └── unicode-xid v0.2.2
│ │ [build-dependencies]
│ │ └── autocfg v1.0.1
│ ├── futures-task v0.3.16
│ ├── pin-project-lite v0.2.7
│ ├── pin-utils v0.1.0
│ ├── proc-macro-hack v0.5.19 (proc-macro)
│ ├── proc-macro-nested v0.1.7
│ └── slab v0.4.4
│ [build-dependencies]
│ └── autocfg v1.0.1
|
@messense — FYI, I just published Moka v0.6.1 to crates.io. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.