Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline format args #340

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Inline format args #340

merged 1 commit into from
Nov 9, 2023

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Nov 9, 2023

Makes the code a bit easier to read. Plus a few unneeded commas.

Some of these require migration to 2021 edition first (another PR)

Makes the code a bit easier to read. Plus a few unneeded commas.

Some of these require migration to 2021 edition first (another PR)
@tatsuya6502
Copy link
Member

Thank you very much for submitting a PR!

I believe we can ignore the failing tests. (See #339 (comment))

@tatsuya6502
Copy link
Member

Memo: Inline format args were introduced in Rust 1.58.0. Moka v0.12.1's MSRV is 1.65.0.

@tatsuya6502 tatsuya6502 self-requested a review November 9, 2023 22:52
@tatsuya6502 tatsuya6502 added this to the v0.12.2 milestone Nov 9, 2023
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, there were lots of places to fix. Thank you for doing this!

@tatsuya6502 tatsuya6502 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into moka-rs:main with commit 2ea735d Nov 9, 2023
6 of 16 checks passed
@nyurik nyurik deleted the inline-args branch November 10, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants