Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Linux cross compile tests (v0.11.x) #335

Merged
merged 5 commits into from
Oct 14, 2023

Conversation

tatsuya6502
Copy link
Member

Update Linux cross compile tests (linux-cross) on the v0.11.x branch.

  • To workaround #333, pin the Rust version to 1.72.1 for the following tests:
    • linux-cross (mips-unknown-linux-musl)
    • linux-cross (mipsel-unknown-linux-musl)
  • Disable fail-fast strategy for linux-cross.
  • Stop using actions-rs GH actions in linux-cross:
    • Stop using actions-rs/toolchain and actions-rs/cargo.
    • Start to use dtolnay/rust-toolchain and taiki-e/install-action.
    • Upgrade actions/checkout from v2 to v4.
  • Apply rustfmt.
  • Disable a Clippy lint clippy::option_env_unwrap in a test.
  • Remove workarounds for a Clippy issue (#301):
    • Remove allow clippy::arc_with_non_send_sync as the false positives have been fixed in Clippy.

Update Linux cross compile tests:

- Stop using `actions-rs/toolchain` and `actions-rs/cargo`.
- Start to use `dtolnay/rust-toolchain` and `taiki-e/install-action`.
- Upgrade `actions/checkout` from v2 to v4.
- Apply rustfmt for `if let ... else`.
- Allow `clippy::option_env_unwrap` in a test.
Remove allow `clippy::arc_with_non_send_sync` as the false positives have been fixed
in Clippy.
@tatsuya6502 tatsuya6502 added this to the v0.11.4 milestone Oct 14, 2023
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 8aafbb1 into v0.11.x Oct 14, 2023
39 checks passed
@tatsuya6502 tatsuya6502 deleted the ci-no-fail-fast-for-cross/v0.11.x branch October 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant