Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to moka-cht #22

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Switch to moka-cht #22

merged 4 commits into from
Aug 3, 2021

Conversation

tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Aug 1, 2021

  • Replace cht v0.4.1, the concurrent hash table implementation, with a fork, moka-cht v0.5.0.
  • Update value_initializer modules to replace moka-cht HashMap with SegmentedHash for better concurrency.
  • Temporary allow clippy::redundant_allocation. (A new lint in Clippy 0.1.54 beta).
    • This will be addressed in Moka v0.6.0 as it requires changing the return type of get_or_try_insert_with.

- Replace cht v0.4.1, the concurrent hash table implementation, with a fork,
  moka-cht v0.5.0.
- Update value_initializer modules to replace moka-cht HashMap with
  SegmentedHash for better concurrency.
- Temporary allow clippy::redundant_allocation [1]. This lint was introduced
  to Clippy 0.1.54 (beta).
  This will be addressed in Moka v0.6.0 as it requires changing the return
  type of `get_or_try_insert_with`

[1]: https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation
@tatsuya6502 tatsuya6502 self-assigned this Aug 1, 2021
- Update future/cache module to temporary allow clippy::redundant_allocation.
  This will be addressed in Moka v0.6.0 as it requires changing the return
  type of `get_or_try_insert_with`.
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

NOTE: The CI jobs at FOSSA seems stall. They are for OSS license compliance check and the jobs are waiting in the queue for a half hour. I do not expect any license issue as previous commits on this branch passed the check.

@tatsuya6502 tatsuya6502 merged commit a737009 into master Aug 3, 2021
@tatsuya6502 tatsuya6502 deleted the switch-to-moka-cht branch August 3, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant