Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lifecycle-mapping-metadata.xml to let eclipse execute the goals. #36

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

akuhtz
Copy link
Contributor

@akuhtz akuhtz commented Jan 5, 2018

No description provided.

@jochenw
Copy link
Member

jochenw commented Jan 5, 2018

In general, open source projects hesitate to add IDE specific files. However, knowing the problem, I tend to ignore this here. However, I will discuss your PR on the mojohaus developers list.

Thanks,

Jochen

@khmarbaise khmarbaise self-requested a review January 5, 2018 19:00
@khmarbaise khmarbaise added this to the Release 1.0.2 milestone Jan 5, 2018
@khmarbaise
Copy link
Member

In general Jochen you are right but those things are an exception cause they make handling in Eclipse very convenient. Apart from that they will not interfere on other platforms..

Copy link
Member

@khmarbaise khmarbaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view this is fine.

@khmarbaise khmarbaise merged commit 32e6e5b into mojohaus:master Jan 5, 2018
@akuhtz
Copy link
Contributor Author

akuhtz commented Jan 5, 2018

@khmarbaise @jochenw Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants