-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NullPointerException in Resolve.java when XInclude href not found, even with fallback provided #40
Comments
Any of the other developers care to comment on whether I need to make a test case for this. Looks like a simple NPE oversight. |
I wouldn't think it worth bothering, if the NPE is fixed. Otoh, if the
default is actually ignored when using something like
<outputDir/>
then I'd definitely suggest that you file a Maven issue, because that is
clearly in violation of the plugin contract.
Jochen
…On Tue, Feb 27, 2018 at 11:22 AM, Ross Lamont ***@***.***> wrote:
Any of the other developers care to comment on whether I need to make a
test case for this. Looks like a simple NPE oversight.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAaGcq8Q5mI6YoL3mbaHeN9tN_MN0JEks5tY9dbgaJpZM4SKxwN>
.
|
Thanks Jochen I will put this through as a simple fix. The outputDir issue is actually bug #41. I've continued the discussion in that thread there. |
I think, I missed the point here. The outputDir is not one a parameter of the Mojo, but a property of one of our beans, right? If so, default handling is our responsibility here, and not Mavens. Sorry! |
Fixed #40. NPE when xinclude is non-existent.
The text was updated successfully, but these errors were encountered: