Upgrade Doxia to 2.x stack

[slawekjaranowski]

No description provided.

[michael-o]

Will take a look...

[michael-o]

There are several problems in src/main/java/org/codehaus/mojo/taglist/TagListReport.java:

• The XRef link calcucation should be done like here: https://github.com/apache/maven-pmd-plugin/blob/c27ea6aabdf95797d0f25f1d60875bf485857aa8/src/main/java/org/apache/maven/plugins/pmd/AbstractPmdReport.java#L87-L101 and here https://github.com/apache/maven-pmd-plugin/blob/c27ea6aabdf95797d0f25f1d60875bf485857aa8/src/main/java/org/apache/maven/plugins/pmd/AbstractPmdReport.java#L286-L323
• Locale handling is wrong:

  taglist-maven-plugin/src/main/java/org/codehaus/mojo/taglist/TagListReport.java

  Lines 148 to 151 in 5bcba29

  	/**
  	* The locale used for rendering the page.
  	*/
  	private Locale currentLocale;

  ,

  taglist-maven-plugin/src/main/java/org/codehaus/mojo/taglist/TagListReport.java

  Lines 528 to 534 in 5bcba29

  	public Locale getLocale() {
  	// The locale string should never be null.
  	if (sourceFileLocale == null) {
  	sourceFileLocale = DEFAULT_LOCALE;
  	}
  	return new Locale(sourceFileLocale);
  	}

  and other spots. That locale solely refers to the locale of the output. See the abstract parent class.
• You should all methods which are already present in the parent class

src/main/java/org/codehaus/mojo/taglist/ReportGenerator.java:

• It should be called ...Renderer and inherit from AbstractMavenReportRenderer
• Maybe move when the move has been done

[slawekjaranowski]

@michael-o - next part of changes ...

[michael-o]

Will import the code into my IDE and do another review.

[michael-o]

sourceFilesLocale, no?

[slawekjaranowski]

We have a sourceFileLocale parameter of Mojo report ... so let to be consistent

[michael-o]

Yes, both need to be consistent with a TODO.

[michael-o]

Is this on purpose:

taglist-maven-plugin/src/main/java/org/codehaus/mojo/taglist/TagListReport.java

Line 368 in 408c9a6

OutputStreamWriter output = new OutputStreamWriter(fos, getInputEncoding())) {

If yes, it should have a comment...

[michael-o]

Regarding:

taglist-maven-plugin/src/main/java/org/codehaus/mojo/taglist/TagListReport.java

Lines 638 to 641 in 408c9a6

	private ResourceBundle getBundle(Locale locale) {
	return ResourceBundle.getBundle(
	"taglist-report", locale, this.getClass().getClassLoader());
	}

Though it is not wrong, the canonical way is to use the I18n class via DI. See PMDReport.java

[michael-o]

Last round of comments

[michael-o]

Also for this plugin:

• [MSHARED-1438] Resolve Code Duplication for XRef Link generation apache/maven-reporting-impl#56
• Draft for MSHARED-1438 apache/maven-pmd-plugin#172

[michael-o]

This good enough, let's go.