Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86 use triple slash to get file protocol working in URLs on windows #87

Merged
merged 1 commit into from
Feb 18, 2020
Merged

#86 use triple slash to get file protocol working in URLs on windows #87

merged 1 commit into from
Feb 18, 2020

Conversation

stefanseifert
Copy link
Collaborator

fixes #86

@stefanseifert stefanseifert self-assigned this Feb 14, 2020
bmarwell
bmarwell approved these changes Feb 14, 2020
View reviewed changes
Copy link

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Explanation:
The default syntax is file://host/path. Host fragment can be omitted, i.e. file:///path.

@stefanseifert stefanseifert merged commit 82bbcb1 into master Feb 18, 2020
@stefanseifert stefanseifert deleted the issue/86 branch February 18, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarwell bmarwell bmarwell approved these changes

Assignees

@stefanseifert stefanseifert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test reserve-ports-with-urls fails on windows
2 participants
@stefanseifert @bmarwell