Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mojaloop/#3439): nodejs upgrade #97

Merged
merged 9 commits into from
Sep 14, 2023
Merged

chore(mojaloop/#3439): nodejs upgrade #97

merged 9 commits into from
Sep 14, 2023

Conversation

aaronreynoza
Copy link
Member

@aaronreynoza aaronreynoza commented Sep 12, 2023 •
edited
Loading

chore(mojaloop/#3439): nodejs upgrade - mojaloop/project#3439

  • Upgraded NodeJS from v16 to v18 LTS
  • Updated CI config to use NodeJS latest LTS version
  • Updated CI config to display runtime versions for each job
  • Upgraded NPM dependencies
  • Fixed CI bugs caused by the NodeJS upgrade
  • Updated CI pipeline use NVM to select node version from .nvmrc file
  • Upgraded circleci orbs
  • Migrated master branch to main
  • Optimized ci workflow to use cached image for some jobs

@aaronreynoza aaronreynoza mentioned this pull request Sep 12, 2023
Closed
5 tasks
mdebarros
mdebarros reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor point for you to address @aaronreynoza.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
aaronreynoza
aaronreynoza commented Sep 14, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
mdebarros
mdebarros approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mdebarros
mdebarros requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the https://github.com/mojaloop/ml-api-adapter/blob/main/.versionrc here.

mdebarros
mdebarros approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronreynoza aaronreynoza merged commit a51ea79 into mojaloop:main Sep 14, 2023
@aaronreynoza aaronreynoza deleted the ML-3439 branch September 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@vgenev vgenev Awaiting requested review from vgenev

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@oderayi oderayi Awaiting requested review from oderayi oderayi is a code owner

@shashi165 shashi165 Awaiting requested review from shashi165

@vijayg10 vijayg10 Awaiting requested review from vijayg10 vijayg10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronreynoza @mdebarros