Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1242: Error framework implementation fixes #23

Merged
merged 5 commits into from
Mar 3, 2020
Merged

#1242: Error framework implementation fixes #23

merged 5 commits into from
Mar 3, 2020

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented Mar 2, 2020 •
edited
Loading

  • Ensured Error instances are duly converted to FSPIOPError and then ErrorInformation object before forwarding as callbacks
  • Added ERROR_HANDLING config
  • Updated unit tests

@oderayi oderayi marked this pull request as ready for review March 2, 2020 17:40
rmothilal
rmothilal approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@elnyry-sam-k elnyry-sam-k mentioned this pull request Mar 3, 2020
Closed
17 tasks
@oderayi oderayi merged commit 7c9a159 into mojaloop:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmothilal rmothilal rmothilal approved these changes

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@matdehaast matdehaast Awaiting requested review from matdehaast

@vijayg10 vijayg10 Awaiting requested review from vijayg10

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@mdebarros mdebarros Awaiting requested review from mdebarros

@vgenev vgenev Awaiting requested review from vgenev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oderayi @rmothilal