Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request error handling #15

Merged
merged 1 commit into from
Jan 14, 2020
Merged

fix: request error handling #15

merged 1 commit into from
Jan 14, 2020

Conversation

matdehaast
Copy link

  • Refactored error handling for authorization and transactionRequests as they both use shared requests library that handles errors internally
  • Fixed transactionRequests error call to send the correct to destination instead of the ENUM

fix:
de9717d 
* Refactored error handling for authorization and transactionRequests as they both use shared requests library that handles errors internally
* Fixed transactionRequests error call to send the correct to destination instead of the ENUM
@matdehaast matdehaast mentioned this pull request Jan 14, 2020
Closed
@elnyry-sam-k elnyry-sam-k requested a review from oderayi January 14, 2020 11:11
oderayi
oderayi approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matdehaast matdehaast merged commit fdd952a into mojaloop:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oderayi oderayi oderayi approved these changes

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@rmothilal rmothilal Awaiting requested review from rmothilal

@DonChangfoot DonChangfoot Awaiting requested review from DonChangfoot

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matdehaast @oderayi