Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add /consentRequests/{ID}/error handler #47

Merged
merged 3 commits into from
Mar 31, 2021
Merged

feat: add /consentRequests/{ID}/error handler #47

merged 3 commits into from
Mar 31, 2021

Conversation

kleyow
Copy link
Collaborator

@kleyow kleyow commented Mar 30, 2021

No description provided.

@kleyow kleyow marked this pull request as ready for review March 30, 2021 20:27
eoln
eoln approved these changes Mar 31, 2021
View reviewed changes
test/unit/server/handlers/consentRequests/{ID}/error.test.ts
})

beforeEach((): void => {
jest.clearAllMocks()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe clearAllMocks should be setup in jest.config ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a follow up. There are tests that need adjusting if I add it as a global config.

@kleyow kleyow merged commit 5e6f56c into mojaloop:master Mar 31, 2021
@kleyow kleyow deleted the feat/put-consent-requests-id-error branch March 31, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoln eoln eoln approved these changes

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@sridharvoruganti sridharvoruganti Awaiting requested review from sridharvoruganti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleyow @eoln