feat(mojaloop/#2704): core-services support for non-breaking backward api compatibility #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… api compatibility - added new feature_test: backward_compatability/fspiop_protocol_validation.json which asserts validations against correct current, old and not-supported versions
elnyry-sam-k
reviewed
Mar 4, 2022
| @@ -66,7 +66,7 @@ | |||
| "id": 2, | |||
| "description": "Add Participant to ALS", | |||
| "meta": { | |||
| "info": "This request allows us to add a new participant to Account Lookup Service." | |||
| "info": "This request allows us to add a new participant to Account Lookup Service.\n\nValidate Not Support Accept header." | |||
There was a problem hiding this comment.
Suggested change
| "info": "This request allows us to add a new participant to Account Lookup Service.\n\nValidate Not Support Accept header." | |
| "info": "This request allows us to add a new participant to Account Lookup Service.\n\nValidate Not Supported Accept header." |
There was a problem hiding this comment.
@elnyry-sam-k those tests have been replaced with GET Parties instead. Please see updates.
…d of post parties.
… api compatibility - Added bulkTransfers tests for protocol validations
elnyry-sam-k
approved these changes
Mar 7, 2022
elnyry-sam-k
approved these changes
Mar 7, 2022
mdebarros
deleted the
feat/#2704-core-services-support-for-non-breaking-backward-api-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2704): core-services support for non-breaking backward api compatibility - mojaloop/project#2704
These are a sub-set of tests as a result of the following investigatory issue: mojaloop/project#2660