-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2092): upgrade nodeJS version for core services #168
feat(mojaloop/#2092): upgrade nodeJS version for core services #168
Conversation
- aligned ci-cd config - added standard-version postchangelog script - updated dependencies
- re-structured project to align to standard mojaloop project repositories. thereby allowing us to re-use CI-CD scripts without modification!
Looking good Miguel, just one minor change from me.. Either mark the PR as breaking change "!" or upgrade package version to v17 or as relevant |
Hey @elnyry-sam-k , I have already marked this as breaking by adding the
|
test-lint
to CI-CD flowstest-dependencies
to CI-CD flowssnapshot
script to package.json. This will auto-bump the npm version withsnapshot.#
and commit both the package/package-lock files. Super useful for working with snapshot releases. This will also create an associated snapshot tag, and all the developer would need to do is push that tag for the snapshot build to be released. This can be done from any branch.Notes:
npm run audit:resolve
(i.e.resolve-audit
) is currently not functioning. As a work-around, we need to manually run the following commandnpm audit fix
. Thenpm run audit:check
(i.e.check-audit
) still works as expected.BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!