Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/add transaction request service endpoint config #205

Conversation

vijayg10
Copy link
Contributor

Bug: When we try to send POST /transactionRequests to the sdk-scheme-adapter, its not able to send the callback.

Fix: Added transactionRequestsEndpoint and TRANSACTION_REQUESTS_ENDPOINT which are missing in the sdk-scheme-adapter. Where as sdk-standard-components library is expecting the config param 'transactionRequestsEndpoint' from sdk-scheme-adapter.

Copy link
Contributor

@lewisdaly lewisdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vijayg10 vijayg10 merged commit 8570228 into mojaloop:master Sep 17, 2020
@vijayg10 vijayg10 deleted the bugfix/add-transaction-request-service-endpoint-config branch September 17, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants