Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: fx and interscheme implementation #353

Merged
merged 53 commits into from
Dec 17, 2024
Merged

feat!: fx and interscheme implementation #353

merged 53 commits into from
Dec 17, 2024

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented Aug 29, 2024 •
edited
Loading

Changes:

  • Currency Conversion (FX)
    • FxQuotes API implementation in both simple routing mode and persistent mode
    • Adjusted participants validation to accommodate FX
  • Interscheme
    • Proxy cache implementation using redis
    • Parameterize switch id
    • Adjusted participants validation to accommodate interscheme
  • Performance optimisations
    • Option to send audit and trace events directly to Kafka instead of using sidecars
    • Allowed UUID v7 in the API patterns

oderayi and others added 30 commits March 8, 2024 11:05
@oderayi
feat(mojaloop/#3689): fx quotes pov implementation (#326)
9bf52f0
@oderayi
chore(snapshot): 15.8.0-snapshot.11
223fbdc
@oderayi
fix(mojaloop/#3689): fx quotes fixes (#328)
dd5d439
@oderayi
fix(mojaloop/#3689): fx quotes bug fix (#329)
349ca83
@kalinkrustev
feat: enable sending events directly to Kafka (#332)
8fcf844
@oderayi
chore: fix merge conflicts
b2d1418
@oderayi
feat(mojaloop/#3933): update participant accounts validation (#333)
1b57edc 
feat(mojaloop/#3933): update participant accounts validation
- Added validation for `supportedCurrencies` when present in `POST /quotes` request (payer DFSP must have position account for all supported currencies
- Added validation for `payeeReceiveAmount` currency when present (payee DFSP must have position account for the `payeeReceiveAmount` currency)
- Fixed error handling to prevent sending double error callbacks
- Ensure top-level tracing spans are finished correctly
- Updated integration tests harness to support new changes
- Added integration tests for the use case
- Updated dependencies and resolve audit issues
@kleyow
add check for db on api, fix docker compose
cd93ed5
@kleyow
chore(snapshot): 15.8.0-snapshot.17
e72a219
@kleyow
disable coverage, fix image scan
45a5bf8
@kleyow
chore(snapshot): 15.8.0-snapshot.18
63e5485
@kleyow
disable coverage, fix image scan
d2057b3
@kleyow
chore(snapshot): 15.8.0-snapshot.19
86ed870
@kleyow
image scan
71b7384
@kleyow
chore(snapshot): 15.8.0-snapshot.20
29904f6
@kleyow
revert
203abca
@kleyow
chore(snapshot): 15.8.0-snapshot.21
0bcb479
@kalinkrustev
feat: allow UUID v7 in the API patterns (#334)
4bae7f7
@oderayi
Merge branch 'feat/fx-impl' of github.com:mojaloop/quoting-service in…
ec4259f 
…to feat/fx-impl
@oderayi
feat(csi-20 & csi-164): parameterize 'switch' id (#339)
df4d342
@vijayg10
fix: quotes participants validation (#340)
a151555 
* fix: quotes validation

* chore(snapshot): 15.8.0-snapshot.22

* fix: integration test

* chore: await in promise all

* fix: lint
@oderayi
Merge branch 'feat/fx-impl' of github.com:mojaloop/quoting-service in…
39b8bf6 
…to feat/fx-impl
@oderayi
chore(snapshot): 15.8.0-snapshot.23
63fd5cf
@oderayi
chore(snapshot): 15.8.0-snapshot.24
5fbe158
@oderayi
feat(mojaloop/#3991): add support for cross-network proxy routing (#341)
8e879f8 
feat(mojaloop/#3991): add support for cross-network proxy routing (#341)
- Added proxy lib
- Added configuration for proxy
- Added unit and integration tests for proxy related functionalities
@kalinkrustev
fix: deps
283f173
@kalinkrustev
chore(snapshot): 15.8.0-snapshot.32
ac17e67
@geka-evk
feat(csi-334): updated proxyCache lib to use redis cluster (#342)
0a0ca9f 
* feat(csi-334): updated proxyCache lib to use redis cluster

* chore(snapshot): 15.8.0-snapshot.33
@geka-evk
fix(csi-414): fixed TypeError - Cannot read properties of undefined; …
ca73b2d 
…updated proxyCache lib; added request logging (#344)

* feat(csi-334): updated proxyCache lib; added request logging

* fix(csi-414): fixed TypeError - Cannot read properties of undefined (reading 'value')
@geka-evk
fix(csi-414): updated deps
c6b141f
@vijayg10 vijayg10 changed the title feat: fx impl feat: fx and interscheme implementation Sep 4, 2024
@kleyow kleyow changed the title feat: fx and interscheme implementation feat!: fx and interscheme implementation Sep 26, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2024
View reviewed changes
Dockerfile Fixed Show fixed Hide fixed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 21, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@elnyry-sam-k
Copy link
Member

A general comment: I couldn't find any changes to readme files corresponding to these updates and on the documentation repo, could only find the PR: mojaloop/documentation#434 for the fx transfers sequences but not quotes.

Please update here if these are provided elsewhere or if they're still needed.

@oderayi oderayi assigned oderayi and unassigned oderayi Dec 2, 2024
@oderayi oderayi self-assigned this Dec 17, 2024
@elnyry-sam-k
Copy link
Member

Thanks Steven, for the updates!

Few comments / questions for clarification:

  1. Is there no ILP packet being returned in the PUT /fxQuotes? to confirm, is it just the condition?
  2. There's also some/servicesrelated requests here, is the implementation for those provided here or is it just represented for context?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@oderayi
Copy link
Contributor

oderayi commented Dec 17, 2024 •
edited
Loading

Thanks Steven, for the updates!

Few comments / questions for clarification:

  1. Is there no ILP packet being returned in the PUT /fxQuotes? to confirm, is it just the condition?
  2. There's also some/servicesrelated requests here, is the implementation for those provided here or is it just represented for context?
  1. Yes, we only need condition in PUT /fxQuotes
  2. I removed services. Vijay confirmed multi-fxps is no longer implemented/supported. FXP detail is added as config in sdk-scheme-adapter.

@oderayi oderayi merged commit bc4e126 into main Dec 17, 2024
13 of 14 checks passed
@elnyry-sam-k elnyry-sam-k mentioned this pull request Jan 8, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinkrustev kalinkrustev kalinkrustev left review comments

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@geka-evk geka-evk geka-evk left review comments

@mdebarros mdebarros Awaiting requested review from mdebarros mdebarros is a code owner

@oderayi oderayi Awaiting requested review from oderayi oderayi is a code owner

@bushjames bushjames Awaiting requested review from bushjames bushjames is a code owner

@kleyow kleyow Awaiting requested review from kleyow kleyow is a code owner

Assignees

@oderayi oderayi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vijayg10 @elnyry-sam-k @oderayi @kalinkrustev @geka-evk @kleyow