Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for docker image to support async logging #202

Merged
merged 5 commits into from
May 6, 2020
Merged

Hotfix for docker image to support async logging #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bb3889
Fix for async logging support on docker image
mdebarros May 6, 2020
efc07e9
Fix for previous commit fix :D
mdebarros May 6, 2020
6432631
removed duplicate user in dockerfile
mdebarros May 6, 2020
fd386f2
Updated dependencies, and bumped version
mdebarros May 6, 2020
5e12439
Typo fix in package.json
mdebarros May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ FROM node:12.16.1-alpine

WORKDIR /opt/quoting-service

# Create empty log file & link stdout to the application log file
RUN mkdir ./logs && touch ./logs/combined.log
# Links combined to stdout
RUN ln -sf /dev/stdout ./logs/combined.log

# Create a non-root user: ml-user
RUN adduser -D ml-user
USER ml-user
Expand All @@ -28,4 +33,4 @@ COPY --chown=ml-user --from=builder /opt/quoting-service .
RUN npm prune --production

EXPOSE 3002
CMD ["npm", "run", "start"]
CMD ["npm", "run", "start"]
10 changes: 10 additions & 0 deletions audit-resolve.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@
"decision": "ignore",
"madeAt": 1588247839507,
"expiresAt": 1588852630163
},
"1500|npm-audit-resolver>yargs-unparser>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1588760499425,
"expiresAt": 1589365290340
},
"1500|npm-audit-resolver>audit-resolve-core>yargs-parser": {
"decision": "ignore",
"madeAt": 1588760504403,
"expiresAt": 1589365290340
}
},
"rules": {},
Expand Down
Loading