Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Revert #1178 changes #161

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Hotfix: Revert #1178 changes #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba9416e
Revert #1178 changes. Update depenedencies. Bump version
oderayi Mar 5, 2020
a5239a9
Undo version bump
oderayi Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"jest": "25.1.0",
"jest-junit": "10.0.0",
"npm-audit-resolver": "2.2.0",
"npm-check-updates": "4.0.3",
"npm-check-updates": "4.0.4",
"nyc": "15.0.0",
"pre-commit": "1.2.2",
"proxyquire": "2.1.3",
Expand Down
9 changes: 0 additions & 9 deletions src/model/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,6 @@ class QuotesModel {
throw ErrorHandler.CreateInternalServerFSPIOPError('Missing quoteRequest', null, fspiopSource)
}

// We need to validate that the FSP Ids in the headers and payload match
if (fspiopSource !== quoteRequest.payer.partyIdInfo.fspId) {
throw ErrorHandler.CreateFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.VALIDATION_ERROR, '"fspiop-source" header does not match the payer FSP ID', null, fspiopSource)
}

if (fspiopDestination !== quoteRequest.payee.partyIdInfo.fspId) {
throw ErrorHandler.CreateFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.VALIDATION_ERROR, '"fspiop-destination" header does not match the payee FSP ID', null, fspiopSource)
}

await this.db.getParticipant(fspiopSource, LOCAL_ENUM.PAYER_DFSP)
await this.db.getParticipant(fspiopDestination, LOCAL_ENUM.PAYEE_DFSP)
}
Expand Down