Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1173 - GET /quotes for unknown quote ID error response is 1001 instead of 3205 #139

Merged
merged 9 commits into from
Feb 10, 2020
Merged

Fix for #1173 - GET /quotes for unknown quote ID error response is 1001 instead of 3205 #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
df727ce
Bump version to 9.0.0-snapshot
oderayi Feb 5, 2020
8cb95cd
Fix response codes for PUT /quotes/{id} and PUT /quotes/{id}/error fr…
oderayi Feb 6, 2020
02056c6
Update dependencies. Freeze json-rules-engine due to breaking changes
oderayi Feb 6, 2020
69e5dbe
Bump version to 9.1.0
oderayi Feb 6, 2020
e359c47
Remove hard-coded response codes in test
oderayi Feb 6, 2020
e948e68
Return error 3000 - Generic client error and not 1001 on 404 errors
oderayi Feb 7, 2020
a5d0f86
Update dependencies
oderayi Feb 7, 2020
3958f73
Fix span bug
oderayi Feb 7, 2020
10a1c93
Update cs-shared
oderayi Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ncurc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"reject": [
"@hapi/hapi",
"@hapi/good"
"@hapi/good",
"json-rules-engine"
]
}
291 changes: 242 additions & 49 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading