Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node JS version for the quoting-service #3438

Closed
6 tasks done
PaulGregoryBaker opened this issue Aug 7, 2023 · 0 comments
Closed
6 tasks done

Update Node JS version for the quoting-service #3438

PaulGregoryBaker opened this issue Aug 7, 2023 · 0 comments
Assignees
@oderayi
Labels
core-dev-squad pi-22 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Aug 7, 2023 •
edited by oderayi
Loading

Tasks:

  • Update all dependencies
  • Verify that ignored dependency upgrades are still applicable .ncurc.yaml
  • Verify that ignored audit issues are still applicable audit-ci.jsonc
  • Update project to the latest LTS Nodejs version run CI tests
  • Update CI workflow based on the latest fixes made to the SDK-Scheme-Adapter CI workflow for NVM, etc.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label Aug 24, 2023
@oderayi oderayi mentioned this issue Sep 5, 2023
Merged
oderayi added a commit to mojaloop/quoting-service that referenced this issue Sep 6, 2023
@oderayi
chore(mojaloop/#3438): nodejs upgrade (#309)
d3aba52 
chore(mojaloop/#3438): nodejs upgrade - mojaloop/project#3438
- Upgraded NodeJS from v16 to v18 LTS
- Updated CI config to use NodeJS latest LTS version
- Updated CI config to display runtime versions for each job
- Upgraded NPM dependencies
- Fixed CI bugs caused by the NodeJS upgrade
- Updated CI pipeline use NVM to select node version from` .nvmrc` file
- Upgraded circleci orbs
- Migrated `master` branch to `main`
- Optimized ci workflow to use cached image for some jobs
- Updated unit test scripts to run "in band" to avoid failures by flaky tests. (Further investigation is needed to ascertain why `test/unit/server.tests.js` and `test/unit/serverStart.test.js` fail when run in parallel)
@JaneS321 JaneS321 closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oderayi oderayi

Labels
core-dev-squad pi-22 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oderayi @PaulGregoryBaker @JaneS321