Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk-api-adapter is unable to process requests with individualTransfers[].extensionLists #2584

Closed
mdebarros opened this issue Nov 19, 2021 · 0 comments
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@mdebarros
Copy link
Member

mdebarros commented Nov 19, 2021

Summary:

Post /bulkTransfer requests are failing when extensionLists are defined in one or more of the individualTransfers due to the following error:

Error: "individualTransfers[0].extensionList" contains link reference "ref:local:c7xjtl83f4" which is outside of schema boundaries
    at new module.exports (/opt/bulk-api-adapter/node_modules/@hapi/hoek/lib/error.js:23:19)
    at module.exports (/opt/bulk-api-adapter/node_modules/@hapi/hoek/lib/assert.js:20:11)
    at Object.internals.assert (/opt/bulk-api-adapter/node_modules/joi/lib/types/link.js:167:5)
    at Object.internals.generate (/opt/bulk-api-adapter/node_modules/joi/lib/types/link.js:113:15)
    at Object.validate (/opt/bulk-api-adapter/node_modules/joi/lib/types/link.js:36:34)
    at Object.exports.validate (/opt/bulk-api-adapter/node_modules/joi/lib/validator.js:325:26)
    at internals.Base.$_validate (/opt/bulk-api-adapter/node_modules/joi/lib/base.js:773:26)
    at Object.validate (/opt/bulk-api-adapter/node_modules/joi/lib/types/keys.js:108:45)
    at Object.exports.validate (/opt/bulk-api-adapter/node_modules/joi/lib/validator.js:325:26)
    at internals.Base.$_validate (/opt/bulk-api-adapter/node_modules/joi/lib/base.js:773:26) {isBoom: true, isServer: false, data: null, output: {…}, stack: 'Error: "individualTransfers[0].extensionList"…-adapter/node_modules/joi/lib/base.js:773:26)', …}

Severity:
High

Priority:
Critical

Expected Behavior

Post /bulkTransfer requests should be processed by the bulk-api-adapter with a valid HTTP accept code.

Steps to Reproduce

  1. Install Mojaloop v13.1.0 Candidate Release
  2. Run the v13.1.0 Provisioning Collection
  3. Run the v13.1.0 Bulk Transfer Test Collection

Specifications

  • Component (if known): bulk-api-adapter
  • Version: v12.0.1 (unconfirmed - most likely impacts older versions)
  • Platform: n/a
  • Subsystem: n/a
  • Type of testing: Testing-Toolkit
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Critical
@mdebarros mdebarros added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Nov 19, 2021
@mdebarros mdebarros self-assigned this Nov 19, 2021
mdebarros added a commit to mdebarros/bulk-api-adapter that referenced this issue Nov 22, 2021
…ith individualTransfers[].extensionLists

fix for mojaloop/project#2584:
- removed linked references in api swagger definition as a temporary work-around due to the internal issue between hapi-swagger and joi dependencies -> this will be addressed in future once it is replaced with openapi-backend plugin
mdebarros added a commit to mojaloop/bulk-api-adapter that referenced this issue Nov 22, 2021
fix(mojaloop/#2584): bulk-api-adapter is unable to process requests with individualTransfers[].extensionLists
- fix for mojaloop/project#2584:
    - removed linked references in api swagger definition as a temporary work-around due to the internal issue between hapi-swagger and joi dependencies -> this will be addressed in future once it is replaced with openapi-backend plugin

fix(mojaloop/#2585): bulk-api-adapter fails when extensionLists are not send in the POST /bulkTransfer requests
- fix for mojaloop/project#2585:
    - updated object-store-lib depenendency

chore: updated gitignore to include devspace files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Development

No branches or pull requests

1 participant