Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralsettlement-service is failing GP tests when enabling event-sdk sidecar on v13.0.1 release candidate #2368

Closed
Tracked by #2343
mdebarros opened this issue Aug 4, 2021 · 2 comments
Closed
Tracked by #2343

Centralsettlement-service is failing GP tests when enabling event-sdk sidecar on v13.0.1 release candidate #2368

mdebarros opened this issue Aug 4, 2021 · 2 comments
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone
Sprint 15.1

Comments

@mdebarros
Copy link
Member

mdebarros commented Aug 4, 2021 •
edited
Loading

Summary:

Centralsettlement-service is failing GP tests when enabling event-sdk sidecar on v13.0.1 release candidate.

Test Suite:[33mGP Tests[39m
Environment:[33mDevelopment[39m
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 1926                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 138                           │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 446                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 99                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 93.31%                        │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Tue, 03 Aug 2021 15:26:55 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Tue, 03 Aug 2021 15:29:16 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 141306 ms                     │
└───────────────────┴───────────────────────────────┘

Workaround: disable sidecar (which is already the case by default).

Severity:
Low

Priority:
Medium

Expected Behavior

GP tests should pass when the sidecar has been enabled on the Centralsettlement-service.

Steps to Reproduce

  1. Deploy release/v13.0.1 branch, ensuring that Centralsettlement-service.sidecar.enable=true in the associated values.yaml file
  2. Run helm test command

Specifications

  • Component (if known): Central-Settlements
  • Version: mojaloop/central-settlement:v13.4.0
  • Platform: n/a
  • Subsystem: Helm v13.0.1 candidate release
  • Type of testing: Manual
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: Low
  • Priority when opened: Medium
@mdebarros mdebarros added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Aug 4, 2021
@mdebarros mdebarros self-assigned this Aug 4, 2021
@mdebarros mdebarros mentioned this issue Aug 4, 2021
Closed
59 tasks
@mdebarros mdebarros added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Aug 4, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.1 milestone Aug 4, 2021
@mdebarros
Copy link
Member Author

PR to fix issue: mojaloop/central-settlement#368

mdebarros added a commit to mojaloop/helm that referenced this issue Aug 4, 2021
@mdebarros
Updates to fix GP verification issues
ddc255a 
- fix(#2368): centralsettlement-failing-GP-tests-with-event-sdk-sidecar (mojaloop/project#2368)
- Upgraded Central-Settlement from 13.14.0 to 13.14.1
@mdebarros
Copy link
Member Author

mdebarros commented Aug 4, 2021 •
edited
Loading

PR to fix issue: mojaloop/central-settlement#368

Release for fix: https://github.com/mojaloop/central-settlement/releases/tag/v13.4.1

GP now passes in PR -> mojaloop/helm#445

�[33m--------------------FINAL REPORT--------------------�[39m

Test Suite:�[33mGP Tests�[39m
Environment:�[33mDevelopment�[39m
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2064                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 446                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 99                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Wed, 04 Aug 2021 16:16:04 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Wed, 04 Aug 2021 16:18:18 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 133760 ms                     │
└───────────────────┴───────────────────────────────┘

@mdebarros mdebarros mentioned this issue Aug 4, 2021
Merged
mdebarros added a commit to mojaloop/helm that referenced this issue Aug 4, 2021
@mdebarros
fix: release/v13.0.1 (#445)
9bc9b8e 
- Upgraded Central-Settlement from v13.4.0 to v13.4.1, fixes errors when `sidecar.enabled=true` issue (mojaloop/project#2368).
- Added missing `default-sidecar.json` to Central-Settlement Template chart
- Added a `.changelog` folder with release notes for v13.0.0 and v13.0.1
- Added additional "commented" values to Testing Toolkit to improve the ease of configurability
-  fixed issue (mojaloop/project#2359) when running TTK deployments in "hosted" mode.
   - Updated Testing Toolkit v13.2.1 to v13.2.2
   - Updated structure to Testing Toolkit (TTK) Backend value for `CONNECTION_MANAGER_AUTH_ENABLED` to `CONNECTION_MANAGER.AUTH_ENABLED`.
mdebarros added a commit to mojaloop/helm that referenced this issue Aug 11, 2021
@mdebarros
fix: release/v13.0.1 (#445)
b4643ca 
- Upgraded Central-Settlement from v13.4.0 to v13.4.1, fixes errors when `sidecar.enabled=true` issue (mojaloop/project#2368).
- Added missing `default-sidecar.json` to Central-Settlement Template chart
- Added a `.changelog` folder with release notes for v13.0.0 and v13.0.1
- Added additional "commented" values to Testing Toolkit to improve the ease of configurability
-  fixed issue (mojaloop/project#2359) when running TTK deployments in "hosted" mode.
   - Updated Testing Toolkit v13.2.1 to v13.2.2
   - Updated structure to Testing Toolkit (TTK) Backend value for `CONNECTION_MANAGER_AUTH_ENABLED` to `CONNECTION_MANAGER.AUTH_ENABLED`.

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart
mdebarros added a commit to mojaloop/helm that referenced this issue Sep 17, 2021
@mdebarros @vijayg10
fix(mojaloop/#2382): release v13.0.2 (#448)
bb0d997 
* fix: release/v13.0.1 (#445)

- Upgraded Central-Settlement from v13.4.0 to v13.4.1, fixes errors when `sidecar.enabled=true` issue (mojaloop/project#2368).
- Added missing `default-sidecar.json` to Central-Settlement Template chart
- Added a `.changelog` folder with release notes for v13.0.0 and v13.0.1
- Added additional "commented" values to Testing Toolkit to improve the ease of configurability
-  fixed issue (mojaloop/project#2359) when running TTK deployments in "hosted" mode.
   - Updated Testing Toolkit v13.2.1 to v13.2.2
   - Updated structure to Testing Toolkit (TTK) Backend value for `CONNECTION_MANAGER_AUTH_ENABLED` to `CONNECTION_MANAGER.AUTH_ENABLED`.

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart

* Updated quoting-service from 12.0.6 to 12.0.7

- Bumped Mojaloop helm charts
- Bumped Quoting-service helm charts
- Upgraded quoting-service from 12.0.6 to 12.0.7
- Updated release notes for v13.0.2

* Bump to mojaloop

* Updated account-lookup-service from v11.7.2 to v11.7.3

* Updated simulator from v11.0.2 to v11.0.3

* Updated account-lookup-service from v11.7.3 to v11.7.4

* Updated 13.0.2 release notes

- Added 2nd PR to fix issue 2374

* Fix typo in release notes

* eventstreamprocessor log_level is now info by default

* fix(mojaloop/#2405): helm release v13.0.x upgrades fail after several iterations

Fixes for mojaloop/project#2405:
- Added duplicate protection for set env vars for the mojaloop-simulator deployment descriptor.
- Uncommented statically configured env vars for the mojaloop-simulator in the values.yaml and removed them from the deployment descriptor.
- Removed breaking mojaloop-simulator configs from the mojaloop/values.yaml. They can still be configured if required, but rather hide configs that should be avoided.
- Parch version bump to mojaloop-simulators Helm chart

* Updated changelog

* Fixed some comments

* - upgraded sdk-scheme-adapter

- from  v11.17.1 -> **v11.18.7**
- minor bump to mojaloop-simulator
- updated v13.0.2 release notes
- Changed default value of liveliness and readiness probes enablement to true on quoting-service

* upgraded quoting-service to v12.0.9

- updated docker images
- updated release notes

* Updated release notes with known issues

* bump to quoting-service to v12.0.10

* added missing allow.auto.create.topics for kafka consumer configs

* updated v13.0.2 release notes for previous commit

* Feature/upgrade ttk (#449)

* Upgraded TTK app versions and bumped up the chart version

* Added release notes

* Upgraded mojaloop-testing-toolkit

- Backend from v13.4.0 to v13.5.2
- UI from v13.4.0 to v13.5.0

* chore: bumped account-lookup-service

- maintenance update on dependencies, no functional changes or bug fixes included in this version bump

* Updates to account-lookup-service

- Bump ALS from v11.7.5 to 11.7.7

* Updated MySQL Configuration to support utf8 encoding

- mojaloop/project#2471

* Added env vars for accented/burmese characters to TTK env config

* updated v13.0.2 release notes with

- Feature notes for mojaloop/project#1452
- Bug fix placeholder (which is pending a fix) for mojaloop/project#2474

* Updated typo

* updated transaction-request-service

- upgraded image from v11.1.5 to v11.1.6
- minor bump to chart version

* bump to transaction-request-service

- updated image to v11.1.7 due to updated readme

* updated ttk frontend

- upgraded v13.5.0 to v13.5.2

* bump to account-lookup and quoting-service chart versions

* chore: maintenance updates

- added initContainer to sdk-scheme-adapter
- added mysql config for utf8mb4 character sets

* chore: lots of updates

- upgraded sdk-scheme-adapter from v11.18.7 t v11.17.8
- upgraded central-ledger components from v13.12.1 to v13.14.0
- chart bumps to reflect the upgrades above
- added checksum annotation on TTK backend to ensure updates restart pods in the statefulset when changes are made
- updated release notes for v13.0.2

* updated release notes

* chore: maintenance update

- added checksum annotations to all supported charts
- patch bump to all charts (where applicable) to reflect the above change
- updated release notes

* updates to release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* feat: parameteriized sim names in ttk env (#450)

* Added parameters logic for extra environments property

* Introduced the parameters for simulator names in ml-testing-toolkit values in mojaloop

* Added parameters logic to TTK CLI chart

* Added parameters to TTK CLI values in the mojaloop values file

* Fixed the issue with TTK CLI chart

* Removed unneccessary anchors

* updating release notes

Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
Sprint 15.1
Development

No branches or pull requests
2 participants
@elnyry-sam-k @mdebarros