Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Typescript to Javascript for production deployment #1814

Closed
8 of 14 tasks
lewisdaly opened this issue Nov 3, 2020 · 0 comments
Closed
8 of 14 tasks

Compile Typescript to Javascript for production deployment #1814

lewisdaly opened this issue Nov 3, 2020 · 0 comments
Assignees
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Milestone

Comments

@lewisdaly
Copy link
Contributor

lewisdaly commented Nov 3, 2020

@eoln commented on Mon Aug 17 2020

Goal:

As a Hub Operator I want to run Typescript services as Javascript so that execution env doesn't have to play with Typescript dependencies
Tasks:

  • find out proper TS->JS translation method (AOT), experiment with output code optimization
  • handle paths shortcuts defined in tsconfig.json and not properly resolved during TS->JS translation
  • drop any Typescript dependencies from production
  • build a container with JS only & adjust docker-compose if needed

Acceptance Criteria:

  • thirdparty-api-service
  • thirdparty-sdk
  • auth-service
  • Unit Tests pass run against Javascript compiled code
  • Integration Tests pass run against Javascript compiled code
  • Code Style & Coverage meets standards
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@lewisdaly lewisdaly added story oss-pisp OSS PISP team's items - stories, bugs, epics labels Nov 3, 2020
@lewisdaly lewisdaly added this to the Sprint 16.1 milestone Nov 2, 2021
@lewisdaly lewisdaly self-assigned this Nov 2, 2021
lewisdaly added a commit to mojaloop/auth-service that referenced this issue Nov 5, 2021
* feat: add pr-title-check step to ci/cd

* chore: change pr-tools orb to 0.1.10

* feat: compile ts to js for production

* fix: config json files are now copied manually

* fix: use js instead of ts for migrations and seeds

* feat: run migrations inside of docker

* fix: bad json formatting

* fix: test coverage

* fix: working on tricky integration test config
lewisdaly added a commit to mojaloop/thirdparty-sdk that referenced this issue Nov 5, 2021
* feat: compile ts to js for production

* feat: remove default secrets

* chore: clean up docker-compose file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-pisp OSS PISP team's items - stories, bugs, epics story
Projects
None yet
Development

No branches or pull requests

1 participant