request module puts all extensions under cause key and breaks Account Lookup Service expectations

[vbarzokas]

Summary:
The central-services-shared/src/util/request.js module puts all extensions under cause key and breaks Account Lookup Service expectations. It does this here and more specifically:

const cause = JSON.stringify(extensionArray)
const fspiopError = ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.DESTINATION_COMMUNICATION_ERROR, 'Failed to send HTTP request to host', error, source, [{ key: 'cause', value: cause }])

The ALS in this block of code expects that there will be an extension list and it will contain the key status in the path extensionList.extensions[] and more specifically:

err.extensions.some(ext => (ext.key === 'status' && (ext.value === Enums.Http.ReturnCodes.BADREQUEST.CODE || ext.value === Enums.Http.ReturnCodes.NOTFOUND.CODE)))

This is currently blocking the Mowali implementation from proceeding further.

Severity:
High

Priority:
Critical

Expected Behavior
The keys put inside the array extensionList.extensions should be accessible by the Account Lookup Service and more specifically the status key.

Steps to Reproduce

1. Make sure that the payee FSP is down/not reachable.
2. Make a request to GET /parties/MSISDN/27634485971 which corresponds to the mentioned payee FSP
3. Inspect the logs of the Account Lookup Service. You will notice something like that which breaks the expectations mentioned above, because all the extensions are under the cause key.
   ... "extensionList":{"extension":[{"key":"cause","value":"[{\"key\":\"url\",\"value\":\"http://mowbkd-als-oracle-pathfinder/participants/MSISDN/27634485971\"},{\"key\":\"sourceFsp\",\"value\":\"testfsp"}]}} ...

Specifications

• Component (if known): central-services-shared
• Version: 9.3.2
• Platform:
• Subsystem:
• Type of testing:
• Bug found/raised by: @vbarzokas

Notes:

• Severity when opened: High
• Priority when opened: Critical

[vbarzokas]

Issue has been addressed with the referenced commits.