Filter out extensionLists when extension element is an empty array

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mojaloop/central-object-store",
-    "version": "6.4.1-snapshot",
+    "version": "6.4.2-snapshot",
     "description": "Mojaloop library for common object store",
     "license": "Apache-2.0",
     "author": "ModusBox",

src/bulkTransfers/models/facade.js

@@ -29,6 +29,12 @@ const BulkTransferResultModelFactory = require('./bulkTransferResult')
 const getBulkTransferResultByMessageIdDestination = async (messageId, destination) => {
   let BulkTransferResultModel = BulkTransferResultModelFactory.getBulkTransferResultModel()
   let message = await BulkTransferResultModel.findOne({ messageId, destination })
+  message.individualTransferResults = message.individualTransferResults.map(tr => {
+    if (!tr._doc.extensionList.extension.length) {
+      delete tr._doc.extensionList
+    }
+    return tr
+  })
   return message.toJSON()
 }
 

src/bulkTransfers/schema/bulkTransfer.js

@@ -74,6 +74,9 @@ const getBulkTransferSchema = () => {
       try {
         this.individualTransfers.forEach(async transfer => {
           try {
+            if (!transfer._doc.extensionList.extension.length) {
+              delete transfer._doc.extensionList
+            }
             let individualTransfer = new IndividualTransferModel({
               _id_bulkTransfers: this._id,
               messageId: this.messageId,
@@ -84,6 +87,9 @@ const getBulkTransferSchema = () => {
             throw e
           }
         })
+        if (!this.extensionList.extension.length) {
+          delete this._doc.extensionList
+        }
       } catch (e) {
         throw (e)
       }

src/bulkTransfers/schema/bulkTransferFulfil.js

@@ -66,6 +66,9 @@ const getBulkTransferFulfilSchema = () => {
       try {
         this.individualTransferResults.forEach(async transfer => {
           try {
+            if (!transfer._doc.extensionList.extension.length) {
+              delete transfer._doc.extensionList
+            }
             let individualTransferFulfil = new IndividualTransferFulfilModel({
               _id_bulkTransferFulfils: this._id,
               messageId: this.messageId,
@@ -77,6 +80,9 @@ const getBulkTransferFulfilSchema = () => {
             throw e
           }
         })
+        if (!this.extensionList.extension.length) {
+          delete this._doc.extensionList
+        }
       } catch (e) {
         throw (e)
       }

src/bulkTransfers/schema/bulkTransferResult.js

@@ -69,6 +69,9 @@ const getBulkTransferResultSchema = () => {
       try {
         this.individualTransferResults.forEach(async transfer => {
           try {
+            if (!transfer._doc.extensionList.extension.length) {
+              delete transfer._doc.extensionList
+            }
             let individualTransferResult = new IndividualTransferResultModel({
               _id_bulkTransferResults: this._id,
               messageId: this.messageId,
@@ -81,6 +84,9 @@ const getBulkTransferResultSchema = () => {
             throw e
           }
         })
+        if (!this.extensionList.extension.length) {
+          delete this._doc.extensionList
+        }
       } catch (e) {
         throw (e)
       }

src/bulkTransfers/schema/individualTransfer.js

@@ -72,6 +72,15 @@ const getIndividualTransferSchema = () => {
         payload: { type: Object, required: true }
       }))
   }
+  IndividualTransferSchema.pre('save', function () {
+    try {
+      if (!this.payload.extensionList.extension.length) {
+        delete this._doc.payload.extensionList
+      }
+    } catch (e) {
+      throw (e)
+    }
+  })
   return IndividualTransferSchema
 }
 

src/bulkTransfers/schema/individualTransferFulfil.js

@@ -60,6 +60,15 @@ const getIndividualTransferFulfilSchema = () => {
         payload: { type: Object, required: true }
       }))
   }
+  IndividualTransferFulfilSchema.pre('save', function () {
+    try {
+      if (!this.payload.extensionList.extension.length) {
+        delete this._doc.payload.extensionList
+      }
+    } catch (e) {
+      throw (e)
+    }
+  })
   return IndividualTransferFulfilSchema
 }
 

src/bulkTransfers/schema/individualTransferResult.js

@@ -63,6 +63,15 @@ const getIndividualTransferResultSchema = () => {
       }))
     IndividualTransferResultSchema.index({ messageId: 1, destination: 1 })
   }
+  IndividualTransferResultSchema.pre('save', function () {
+    try {
+      if (!this.payload.extensionList.extension.length) {
+        delete this._doc.payload.extensionList
+      }
+    } catch (e) {
+      throw (e)
+    }
+  })
   return IndividualTransferResultSchema
 }