Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2151): helm-release-v12.1.0 #106

Merged

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Jun 7, 2021

- Updated dependencies
- Fixes for updated depenencies
- Bump patch version
- Fixed lint issues
- Added dep:check/update scripts for main project and libs, and added "all" variant using npm-run-all
@mdebarros
Copy link
Member Author

mdebarros commented Jun 7, 2021

I am not 100% this PR is LGTM yet, I suspect that the json-rules-engine breaking changes are quite extensive and are not fully dated by existing tests -> https://github.com/CacheControl/json-rules-engine/blob/master/CHANGELOG.md.

Going to create a temp docker image for this, and run some tests on OSS environments to see if I can pick up any issues.

- `Error: Cannot find module 'openapi-jsonschema-parameters'` error
- AJV unknown keyword: 'example' error
@mdebarros
Copy link
Member Author

I am not 100% this PR is LGTM yet, I suspect that the json-rules-engine breaking changes are quite extensive and are not fully dated by existing tests -> https://github.com/CacheControl/json-rules-engine/blob/master/CHANGELOG.md.

Going to create a temp docker image for this, and run some tests on OSS environments to see if I can pick up any issues.

{
app: 'simulator',
request: { id: 'amuck-glove-accurate-fairies', path: '/', method: 'GET' },
response: {
body: { message: 'events.map is not a function', statusCode: 400 },
status: 400
},
msg: 'Request processed',
timestamp: '2021-06-08T09:02:39.832Z'
}

The issue is most likely here --> https://github.com/mojaloop/mojaloop-simulator/blob/master/src/lib/rules-engine/index.js#L80. Which is due to the breaking changes introduced by upgrading json-rules-engine dependency.

@mdebarros mdebarros marked this pull request as draft June 8, 2021 09:06
@mdebarros
Copy link
Member Author

mdebarros commented Jun 8, 2021

I am not 100% this PR is LGTM yet.

Also had to address the error below:

Error: Cannot find module 'openapi-jsonschema-parameters'
Require stack:
- /src/lib/validate/index.js
- /src/index.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:981:15)
at Function.Module._load (internal/modules/cjs/loader.js:863:27)
at Module.require (internal/modules/cjs/loader.js:1043:19)
at require (internal/modules/cjs/helpers.js:77:18)
at Object.<anonymous> (/src/lib/validate/index.js:27:28)
at Module._compile (internal/modules/cjs/loader.js:1157:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1177:10)
at Module.load (internal/modules/cjs/loader.js:1001:32)
at Function.Module._load (internal/modules/cjs/loader.js:900:14)
at Module.require (internal/modules/cjs/loader.js:1043:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [ '/src/lib/validate/index.js', '/src/index.js' ]
}

npm install --production does not install the openapi-jsonschema-parameters dependency from the lib/validate library even though it is in the package-lock.json.

@mdebarros mdebarros marked this pull request as ready for review June 8, 2021 09:56
@mdebarros
Copy link
Member Author

mdebarros commented Jun 8, 2021

I am not 100% this PR is LGTM yet, I suspect that the json-rules-engine breaking changes are quite extensive and are not fully dated by existing tests -> https://github.com/CacheControl/json-rules-engine/blob/master/CHANGELOG.md.

Going to create a temp docker image for this, and run some tests on OSS environments to see if I can pick up any issues.

Tested using OSS dev3 environment. Fixed all errors/issues that I was able to find. It LGTM now! :D/

TTK GP Tests are all passing using mdebarros/mojaloop-simulator:11.4.3-snapshot.4

┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 1568                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 1568                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 299                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 61                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Tue, 08 Jun 2021 09:58:50 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Tue, 08 Jun 2021 10:00:23 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 93167 ms                      │
└───────────────────┴───────────────────────────────┘

@mdebarros mdebarros merged commit d5e777d into mojaloop:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants