Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve http client connections using http keepalive #155

Merged
merged 16 commits into from
May 6, 2021

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented May 5, 2021

No description provided.

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 minor comment for your attention.

src/lib/httpAgentStore.js Outdated Show resolved Hide resolved
@vijayg10 vijayg10 requested a review from mdebarros May 6, 2021 13:31
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

Although I would recommend in future considering using something like Tarn.js to manage your resource pool for the HTTP Clients --> https://github.com/vincit/tarn.js/

@vijayg10 vijayg10 merged commit fbcaf58 into mojaloop:master May 6, 2021
@vijayg10 vijayg10 deleted the feature/improve-tls-http-clients branch May 6, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants