Hotfixes for POST-GET /transfer operations #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added sourceFsp and destinationFsp params to the transformHeaders. It will not use those fields to set the FSPIOP Source and Destination headers - transformHeaders will now remove the FSPIOP Signature when the sourceFsp matches the switch regex - Created enums for all headers and switch regex and value - Updated Notification Handler to set the sourceFsp and destinationFsp for all Callback requests which are mapped from the Message.value.to & Message.value.from values respectively. These should be correctly set by the Central-Ledger or otherwise passed-through by the request. General changes: - New config for ENDPOINT_SECURITY.TLS.rejectUnauthorized to enable or disable Certificate validation. Note that this will default to 'true' if not configured in either the default.json config file or through an environment parameter. Todo: - Fix unit tests - Verify Integration Tests - Enums in ml-api-adapter and central-ledger need to be consolidated into a central library or otherwise have an API on central-ledger to query the shared values.
- Bumped up version to 5.4.0 - moved 'methods' in transfer handler to enums - moved defaulting of the rejectUnauthorized config into the /src/lib/config.js
- added enums for transferEventType & transferActionType - updated notification handler to use the transferActionType enum - rolled back change for the rejectUnauthroized config defaulting. Change was too complicated, and it was decided that this should fail if its not added to the default.json.
mdebarros
requested review from
ggrg,
elnyry-sam-k,
NicoDuvenage,
rmothilal and
HenkKodde
ggrg
requested changes
Mar 19, 2019
ggrg
approved these changes
Mar 19, 2019
Closed
7 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for mojaloop/project#687 which includes fixes for:
switchsourceFpsanddestinationFspto correctly set theFSPIOP-SourceandFSPIOP-Destinationheaders, and transform the headers with the changes described above.Maintenance changes:
rejectUnauthorizedconfig to thedefault.jsonfor Callbacks. Please ensure that you updated yourdefault.jsonto add this new config parameter.