Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated notification handler #73

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Updated notification handler #73

merged 5 commits into from
Oct 30, 2018

Conversation

mdebarros
Copy link
Member

  1. Updated logging to add the cid/transferId where it was available.
  2. Updated the SendCallback function to return a promise. Kafka Commits would not wait for the Callbacks to complete.

@mdebarros
Updated notification handler
db4446b 
1. Updated logging to add the cid/transferId where it was available.
2. Updated the SendCallback function to return a promise.  Kafka Commits would not wait for the Callbacks to complete.
@mdebarros mdebarros self-assigned this Oct 30, 2018
@mdebarros mdebarros added bug Something isn't working enhancement New feature or request labels Oct 30, 2018
rmothilal
rmothilal requested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

src/handlers/notification/index.js Show resolved Hide resolved
rmothilal
rmothilal approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@mdebarros mdebarros merged commit e5be7a8 into mojaloop:feature/perf3.7-enhancements Oct 30, 2018
@rasputtintin rasputtintin mentioned this pull request Aug 24, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@rasputtintin rasputtintin mentioned this pull request Dec 19, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@rmothilal rmothilal rmothilal approved these changes

Assignees

@mdebarros mdebarros

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdebarros @elnyry-sam-k @rmothilal