Feature/410 user friendly message #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: 1. config Kafka config 2. health end-point 3. fix functional-runner.sh
…update some commands to align with template
CI, CD setup and refactoring
* Updating correct path (based on repo/project name) * Removing running five bells ledger tests
* changes for story#276 * changes for story#276 after review * changes for story#276 after review * changes for story#276 after review * changes for story#276 after review-removed unwanted files * changes for story#276 after review-removed unwanted files * changes for story#276 after review-changed the kafka topic name
…13) * Updated the notification handler to accept fulfilment * removed space * Updated the notifications handler Updated the notifications handler with changes from the review comments * Merge from mojaloop dev merge * Fixed integration tests
* fixes for issues experienced on ml-api adapter fixes for tests * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' (#15) * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' * fixed unit tests
* Added handling for payee rejections * Added unit test to cover 100% branches
* Fix for #34 * changes for story 323 * Fix for #33 * Fixed unit test coverage * Fixed test coverage * Fix for bug #34 (#36) * Fix for #34 * Fixed test coverage * fixed the unit tests * integration test * integration tests * integration tests * fixed the bug with notificatin handler * bug #424 fixed
* updates for Date Header * updates for Date Header * added more unit tests
…tabase; Incrementing snapshot version (#54)
… config (#53) * Fixed the spelling FSPIOP * separated the caching logic from hapi server * removed unused helper.js * removed unused helper.js * added the unit and coverage tests * changed the name ENDPOINT_CACHE_URI * change the name ENDPOINT_CACHE_URI * removed the used helper.test.js * refactored the code * fixed the coverage tests * code cleanup * refactored the code as per suggestion by miguel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.