Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2557): error notification to payer fsp, header for source having wrong value #488

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Nov 8, 2021

  • fix for In error notification to Payer FSP, header for source having wrong value project#2557
  • added new event type "ABORT_VALIDATION" branch to allow for notification handler to provide a correct destination header mapping when error when validation fails (i.e. invalid fulfilment)
  • added unit tests for processing "ABORT_VALIDATION" events
  • chore: updated dependencies
    • main update to central-services-shared
    • updated all other dependencies
    • fixed audit-resolve issues

… wrong value

- fix for mojaloop/project#2557
- added new event type "ABORT_VALIDATION" branch to allow for notification handler to provide a correct destination header mapping when error when validation fails (i.e. invalid fulfilment)
Copy link
Contributor

@lewisdaly lewisdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the best way to go about testing this?

src/handlers/notification/index.js Outdated Show resolved Hide resolved
@mdebarros mdebarros self-assigned this Nov 8, 2021
- main update to central-services-shared
- updated all other dependencies
- fixed audit-resolve issues
@mdebarros mdebarros marked this pull request as ready for review November 10, 2021 16:41
@mdebarros mdebarros merged commit 42f079f into mojaloop:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants