fix(mojaloop/#2536): fspiop api version negotiation not handled by transfers service #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated ci dependency cache to use the commit sha instead of the package.json checksum. this will ensure that builds never re-use stale caches going forward! - added release and git-release jobs to CI-CD pipeline - removed deploy from ci-cd pipeline
- removed deprecated faucet dependency (replaced by tap-spec) - added yarn.lock to gitignore
…ansfers service - added getOptionsForFSPIOPHeaderValidation to the plugin configuration - added new config key for PROTOCOL_VERSIONS BREAKING CHANGE: New config key for PROTOCOL_VERSIONS
…rc ignore list as the upgrade is breaking - will have to address this on most mojaloop projects going forward
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165,
vgenev and
vijayg10
as code owners
elnyry-sam-k
previously approved these changes
Oct 19, 2021
…LIDATELIST - MLAPI_PROTOCOL_VERSIONS__ACCEPT__VALIDATELIST can be set as follows "[ \"1\", \"1.1\"]" and it will be parsed correctly into a object - Note that MLAPI_PROTOCOL_VERSIONS__ACCEPT__DEFAULT is not currently used by the ML-API-Adapter, I have not included this in the default.json, but it can be set (when implemented in future). I have also added a comment in the config.js to reflect this. BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The `LIB_RESOURCE_VERSIONS` env var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.
elnyry-sam-k
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The
LIB_RESOURCE_VERSIONSenv var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.