Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#323 notification handler for reject timeout #43

Conversation

shashi165
Copy link
Contributor

Story 323 : Implement Notification Handler for Rejections & time-outs in ml-api-adapter

  1. added the logic to send callback notification for reject/abort and timeouts
  2. fixed the integration tests

Unit Tests

1..120
# tests 120
# pass  120

# ok

Coverage Tests

=============================== Coverage summary ===============================
Statements   : 100% ( 357/357 )
Branches     : 100% ( 92/92 )
Functions    : 100% ( 38/38 )
Lines        : 100% ( 357/357 )
================================================================================

1..120
# tests 120
# pass  120

# ok

Integration Tests

  <testsuite tests="0" failures="0" errors="0" name="setup"/>
  <testsuite tests="0" failures="0" errors="0" name="transfer service"/>
  <testsuite tests="0" failures="0" errors="0" name="prepare should"/>
  <testsuite tests="2" failures="0" errors="0" name="produce a transfer message to kafka">
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler"/>
  <testsuite tests="1" failures="0" errors="0" name="setup connect to kafka">
  <testsuite tests="0" failures="0" errors="0" name="setup disconnect from kafka"/>
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler should"/>
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a PREPARE message and send POST callback">
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a PREPARE message and send PUT callback on error">
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a COMMIT message and send PUT callback">
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a COMMIT message and send PUT callback on error">
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a REJECT message and send PUT callback">
  <testsuite tests="2" failures="0" errors="0" name="Notification Handler should consume a ABORT message and send PUT callback">
  <testsuite tests="1" failures="0" errors="0" name="Notification Handler should consume a TIMEOUT-RECEIVED message and send PUT callback">
  <testsuite tests="0" failures="0" errors="0" name="Notification Handler should tear down"/>

mdebarros and others added 14 commits August 23, 2018 15:07
…tent-LengthFieldUnlessItMatchesThatExactCase' into hotfix/#33ML-API-AdapterErrorcallbacksarenotconformingtotheMojaloopv1.0specification
* Fix for mojaloop#34

* Fixed test coverage
…rorcallbacksarenotconformingtotheMojaloopv1.0specification
…ix/#33ML-API-AdapterErrorcallbacksarenotconformingtotheMojaloopv1.0specification
…lbacksarenotconformingtotheMojaloopv1.0specification

Bug fixes for mojaloop#33 & mojaloop#34
@shashi165 shashi165 self-assigned this Aug 27, 2018
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shashi165 shashi165 merged commit e097765 into mojaloop:develop Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants