Feature/updated dependencies #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aloop#25) * added the consumer code for story mojaloop#197 * added the http headers, schema validations, msg format for kafka sotry#197 * story mojaloop#197 added the notification handler * added the test case * added test cases for story 197 * added test cases for story 197 * Updated a couple of files to support the functional test TODO: 1. config Kafka config 2. health end-point 3. fix functional-runner.sh * Added health endpoint and cleaned up package.json * updated .nvmrc * updates for running functional tests * fixed functional tests for story#197 * Fix merge conflicts * added integration test * made changes after the code review suggestions * unit tests * fixed some unit tests issues with notification handler tests * added unit tests * Correct path in startup command * Updating circleCI config to enable integration, functional tests and update some commands to align with template * Commit to trigger build (for PR) * Refactoring for parameterizing, updating paths, etc * Dependency issue, testing if its related to 'restoring cache' failure * Updating correct path (based on repo/project name) (mojaloop#8) * Updating correct path (based on repo/project name) * Removing running five bells ledger tests * Updates regarding issue with building docker image (mojaloop#10) * Updating dockerfile (mojaloop#12) * Feature/mojaloop#276 consume fulfill (mojaloop#6) * changes for story#276 * changes for story#276 after review * changes for story#276 after review * changes for story#276 after review * changes for story#276 after review-removed unwanted files * changes for story#276 after review-removed unwanted files * changes for story#276 after review-changed the kafka topic name * Feature/mojaloop#275 implementSendingNotificationsToParticipant(payer,payee) (mojaloop#13) * Updated the notification handler to accept fulfilment * removed space * Updated the notifications handler Updated the notifications handler with changes from the review comments * Merge from mojaloop dev merge * Fixed integration tests * fixes for issues experienced on ml-api adapter fixes for tests (mojaloop#14) * fixes for issues experienced on ml-api adapter fixes for tests * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' (mojaloop#15) * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' * fixed unit tests * Feature/pi2demo fixes (mojaloop#16) * fixes for issues experienced on ml-api adapter fixes for tests * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' (mojaloop#15) * re-aligning notification logic to '2.1.3. Transfer Handler Consume (Success)' flow. Notification handler expecting action of 'fulfil' where as per SDs it should be 'commit' * fixed unit tests * change return code to 200 and fixed test * updated common streaming lib for latest version of node-rdkafka (mojaloop#17) * Hotfix for Issue mojaloop#370 (mojaloop#19) * Fix for mojaloop/project#370 * Bumped up the version from 1.86.2 to 1.86.3 * Aligned version names to the end of PI2.4 (being 1.86.2) with 2.4.1 being the hotfix * update producer to validate if one exists already (mojaloop#18) * update producer to validate if one exists already * fixing test coverage * fixes for producer singleton not being created and fix tests * PI2 & PI3 Fix for Producer.disconnect() (mojaloop#24) * Fix for mojaloop/project#370 * Bumped up the version from 1.86.2 to 1.86.3 * Aligned version names to the end of PI2.4 (being 1.86.2) with 2.4.1 being the hotfix * Updated Producer factory disconnect function to correctly function against singleton factory pattern. Also fixed Unit tests. * Fixed unit test coverage. * Added dependency for "rewire" to stub the internal method calls of the Producer Unit Tests
# Conflicts: # .ncurc.json # package-lock.json # package.json
vgenev
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: