Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ml-api-adapter does not support calling call-back end-points that are provided with untrusted certificates #29

Closed
mdebarros opened this issue Aug 13, 2018 · 3 comments
Closed

ml-api-adapter does not support calling call-back end-points that are provided with untrusted certificates #29

mdebarros opened this issue Aug 13, 2018 · 3 comments
Assignees
@mdebarros
Labels
bug Something isn't working

Comments

@mdebarros
Copy link
Member

mdebarros commented Aug 13, 2018 •
edited by elnyry-sam-k
Loading

Issue

ml-api-adapter does not support calling call-back end-points that are provided with untrusted certificates.

This is the error provided by the call-back code:

Error: self signed certificate
    at TLSSocket.<anonymous> (_tls_wrap.js:1103:38)
    at emitNone (events.js:106:13)
    at TLSSocket.emit (events.js:208:7)
    at TLSSocket._finishInit (_tls_wrap.js:637:8)
    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:467:38) {code: DEPTH_ZERO_SELF_SIGNED_CERT,
stack: Error: self signed certificate
    at TLSSocket.<a…TLSWrap.ssl.onhandshakedone (_tls_wrap.js:467:38),
message: self signed certificate}

Resolution

This can be resolved by either 1 of the 2 options:

  1. A simulator end-point that utilizes a trusted certificate is provided
  2. Mojaloop OSS Team updates the ml-api-adapter to ignore untrusted certificates (recommended)
  3. Mojaloop OSS Team updates the ml-api-adapter to utilise a provided certificate
@mdebarros mdebarros added the bug Something isn't working label Aug 13, 2018
@mdebarros
Copy link
Member Author

mdebarros commented Aug 13, 2018 •
edited
Loading

Created a Hotfix release for this: https://github.com/mojaloop/ml-api-adapter/releases/tag/v3.3.1-snapshot from v3.3.0-snapshot code-base.

@mdebarros mdebarros self-assigned this Aug 13, 2018
@mdebarros mdebarros mentioned this issue Aug 13, 2018
Closed
20 tasks
mdebarros added a commit to mdebarros/ml-api-adapter that referenced this issue Aug 13, 2018
@mdebarros
3.3.1-snapshot hotfix
0fb37de 
Fix for the following issue: mojaloop#29
@mdebarros mdebarros mentioned this issue Aug 13, 2018
Merged
@mdebarros
Copy link
Member Author

Fixed in PR #30

mdebarros added a commit that referenced this issue Aug 13, 2018
@mdebarros
Hotfix for #29 ml-api-adapter does not support calling call-back end-…
10910cc 
…points that are provided with untrusted certificates (#30)

* 3.3.1-snapshot hotfix

Fix for the following issue: #29

* Updated sinon
@mdebarros
Copy link
Member Author

PR merged and closed.

@snyk-bot snyk-bot mentioned this issue May 14, 2021
Open
@rasputtintin rasputtintin mentioned this issue May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdebarros