Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation #496

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Sep 1, 2022

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880

  • upgraded mojaloop-simulator to v13.0.1
  • upgraded central-settlement to v15.0.0
  • upgraded central-ledger to v15.1.2.1
  • updated TTK Test-Collection to v14.0.0.1
  • upgraded central-settlements from v14.0.0 to v14.0.0.1-snapshot.1 ~ (TODO: upgrade to final release version)
  • upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1 ~ (TODO: upgrade to final release version)
  • updated testCasesZipUrl & testCasesPathInZip overrides for internal testing pointing to feature branch with associated TTK Test-changes ~ (TODO: undo, and remove comments)
  • commented-out post-hook jobs to support the above change with an applicable TODO comment ~ (TODO: undo, and remove comments)
  • added TODOs to indicate that its temporary (TO BE REMOVED on FINAL PR) ~ (TODO: undo, and remove comments)

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880
- upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880
- upgraded central-settlements from v14.0.0 to v14.0.0.1-snapshot.1
…Zip overrides for internal testing

- updated `testCasesZipUrl` & `testCasesPathInZip` overrides for internal testing pointing to feature branch with associated TTK Test-changes
- commented-out post-hook jobs to support the above change with an applicable TODO comment
- added TODOs to indicate that its temporary (TO BE REMOVED on FINAL PR)
@mdebarros
Copy link
Member Author

mdebarros commented Sep 2, 2022

Testing Toolkit Report
Test Result: PASSED
Test Suite: GP Tests
Environment: moja2.test.mojaloop.live@v14.0.0
Total assertions: 2614
Passed assertions: 2614
Failed assertions: 0
Total requests: 590
Total test cases: 130
Passed percentage: 100.00%
Started time: Fri, 02 Sep 2022 09:07:59 GMT
Completed time: Fri, 02 Sep 2022 09:11:05 GMT
Runtime duration: 186414 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja2.test.mojaloop.live@v14.0.0
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Fri, 02 Sep 2022 09:12:14 GMT
Completed time: Fri, 02 Sep 2022 09:12:40 GMT
Runtime duration: 25406 ms

View Report

- mojaloop-simulator from v13.0.0 to v13.0.1-snapshot.1
- central-ledger from v15.1.2.1-snapshot.1 to 15.1.2.1-snapshot.3
- bumped `v15.1.2.1-snapshot.3` to `v15.1.2.1`
@mdebarros
Copy link
Member Author

Testing Toolkit Report
Test Result: PASSED
Test Suite: GP Tests
Environment: moja2.test.mojaloop.live@v14.0.0
Total assertions: 2634
Passed assertions: 2634
Failed assertions: 0
Total requests: 598
Total test cases: 130
Passed percentage: 100.00%
Started time: Thu, 08 Sep 2022 10:56:26 GMT
Completed time: Thu, 08 Sep 2022 10:59:39 GMT
Runtime duration: 192917 ms

View Report

Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja2.test.mojaloop.live@v14.0.0
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Thu, 08 Sep 2022 11:00:02 GMT
Completed time: Thu, 08 Sep 2022 11:00:28 GMT
Runtime duration: 25488 ms

View Report

- cleaned-up values from temporary test configs
@mdebarros mdebarros marked this pull request as ready for review September 8, 2022 14:41
Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdebarros mdebarros merged commit 8ece499 into master Sep 9, 2022
@mdebarros mdebarros deleted the feat/#2880-simplify-liquidity-cover-check-and-fix-issue-with-validation branch October 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants