-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation #496
Merged
mdebarros
merged 9 commits into
master
from
feat/#2880-simplify-liquidity-cover-check-and-fix-issue-with-validation
Sep 9, 2022
Merged
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation #496
mdebarros
merged 9 commits into
master
from
feat/#2880-simplify-liquidity-cover-check-and-fix-issue-with-validation
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded central-settlements from v14.0.0 to v14.0.0.1-snapshot.1
…Zip overrides for internal testing - updated `testCasesZipUrl` & `testCasesPathInZip` overrides for internal testing pointing to feature branch with associated TTK Test-changes - commented-out post-hook jobs to support the above change with an applicable TODO comment - added TODOs to indicate that its temporary (TO BE REMOVED on FINAL PR)
|
- mojaloop-simulator from v13.0.0 to v13.0.1-snapshot.1 - central-ledger from v15.1.2.1-snapshot.1 to 15.1.2.1-snapshot.3
- bumped `v15.1.2.1-snapshot.3` to `v15.1.2.1`
|
- cleaned-up values from temporary test configs
mdebarros
requested review from
elnyry-sam-k,
rmothilal and
vijayg10
as code owners
September 8, 2022 14:41
elnyry-sam-k
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
mdebarros
deleted the
feat/#2880-simplify-liquidity-cover-check-and-fix-issue-with-validation
branch
October 4, 2022 08:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880
upgraded central-settlements from v14.0.0 to v14.0.0.1-snapshot.1 ~ (TODO: upgrade to final release version)upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1 ~ (TODO: upgrade to final release version)updatedtestCasesZipUrl
&testCasesPathInZip
overrides for internal testing pointing to feature branch with associated TTK Test-changes ~ (TODO: undo, and remove comments)commented-out post-hook jobs to support the above change with an applicable TODO comment ~ (TODO: undo, and remove comments)added TODOs to indicate that its temporary (TO BE REMOVED on FINAL PR) ~ (TODO: undo, and remove comments)