fix/1107-circleci-deploy #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lewisdaly
commented
Feb 28, 2020
lewisdaly
commented
- Update CircleCI deploy config to deploy the quoting-service after a release
- uses new circleci orb to accomplish this
- remove redundant duplicated CircleCI config
- currently deploys to testci namespace on dev1 cluster, but this can be modified from CircleCI params
- part of #1107
35 tasks
lewisdaly
requested review from
aaronreynoza,
KamuelaFranco and
elnyry-sam-k
elnyry-sam-k
previously approved these changes
Feb 28, 2020
KamuelaFranco
previously requested changes
Feb 28, 2020
There was a problem hiding this comment.
Thank you @lewisdaly for this tremendous simplification of the CI config! I've added a few minor notes that reflect our day-to-day findings in this repo in particular that maybe you could ponder.
…ix/1107-circleci-deploy
…ix/1107-circleci-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.