Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/#2801): update sequence diagrams to handle negative validation fulfil #385

Merged
merged 8 commits into from
Aug 19, 2022
Merged

feat(mojaloop/#2801): update sequence diagrams to handle negative validation fulfil #385

merged 8 commits into from
Aug 19, 2022

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Aug 12, 2022 •
edited
Loading

feat(mojaloop/#2801): update sequence diagrams to handle negative validation fulfil - mojaloop/project#2801

  • Add/update ABORTING bulkTransferState for validation failures
  • Update fulfil handler loop for sending messages to abort individualTransfers in a bulktransfer

@kleyow kleyow changed the title Feat/validation abort feat: update sequence diagrams to handle negative validation fulfil Aug 12, 2022
@kleyow kleyow changed the title feat: update sequence diagrams to handle negative validation fulfil feat(mojaloop/#2801): update sequence diagrams to handle negative validation fulfil Aug 12, 2022
elnyry-sam-k
elnyry-sam-k previously approved these changes Aug 12, 2022
View reviewed changes
mdebarros
mdebarros previously approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But it would be good to walk through these changes with you, @elnyry-sam-k and @PaulGregoryBaker in a meeting

@kleyow kleyow dismissed stale reviews from mdebarros and elnyry-sam-k via e2dea0f August 12, 2022 17:01
@kleyow kleyow merged commit ccc7132 into master Aug 19, 2022
@mdebarros mdebarros deleted the feat/validation-abort branch July 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@mdebarros mdebarros mdebarros left review comments

@millerabel millerabel Awaiting requested review from millerabel millerabel is a code owner

@kjw000 kjw000 Awaiting requested review from kjw000

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@simeonoriko simeonoriko Awaiting requested review from simeonoriko simeonoriko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleyow @elnyry-sam-k @mdebarros